Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(element): radio/checkbox add optionType prop #2114

Merged
merged 2 commits into from
Sep 6, 2021
Merged

feat(element): radio/checkbox add optionType prop #2114

merged 2 commits into from
Sep 6, 2021

Conversation

muuyao
Copy link
Collaborator

@muuyao muuyao commented Sep 6, 2021

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content

What have you changed?

feat(element): radio/checkbox add optionType prop

@codecov
Copy link

codecov bot commented Sep 6, 2021 •
edited
Loading

Codecov Report

Merging #2114 (c81d4b6) into formily_next (48f574e) will increase coverage by 0.62%.
The diff coverage is 97.82%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #2114      +/-   ##
================================================
+ Coverage         92.70%   93.33%   +0.62%     
================================================
  Files               136      137       +1     
  Lines              6114     6148      +34     
  Branches           1520     1525       +5     
================================================
+ Hits               5668     5738      +70     
+ Misses              442      406      -36     
  Partials              4        4
Impacted Files Coverage Δ
packages/core/src/models/Form.ts 99.38% <90.00%> (-0.32%) ⬇️
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.21% <100.00%> (+<0.01%) ⬆️
packages/core/src/models/Heart.ts 100.00% <100.00%> (ø)
packages/core/src/models/ObjectField.ts 100.00% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 100.00% <100.00%> (+4.20%) ⬆️
packages/json-schema/src/compiler.ts 96.66% <0.00%> (-0.11%) ⬇️
packages/reactive/src/batch.ts 100.00% <0.00%> (ø)
packages/reactive/src/index.ts 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f87569...c81d4b6. Read the comment docs.

@janryWang janryWang merged commit 54072a6 into alibaba:formily_next Sep 6, 2021
@muuyao muuyao deleted the fix-element-component branch September 28, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muuyao @janryWang